lib: include url in bootstrap snapshot and remove unnecessary lazy-loads

PR-URL: #38826 Refs: #35711 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
nodejs · Jun 2, 2021 · 4884991 · 4884991
1 parent eb7c932
commit 4884991
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 9 deletions.
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
@@ -362,6 +362,7 @@ process.emitWarning = emitWarning;
 require('fs');
 require('v8');
 require('vm');
+require('url');
 
 function setupPrepareStackTrace() {
   const {

diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -70,8 +70,7 @@ const {
   validateObject,
 } = require('internal/validators');
 
-// Lazy loaded for startup performance.
-let querystring;
+const querystring = require('querystring');
 
 const { platform } = process;
 const isWindows = platform === 'win32';
@@ -1046,7 +1045,6 @@ function parseParams(qs) {
       } else if (encodeCheck > 0) {
         if (isHexTable[code] === 1) {
           if (++encodeCheck === 3) {
-            querystring = require('querystring');
             encoded = true;
           }
         } else {

diff --git a/lib/url.js b/lib/url.js
@@ -32,6 +32,7 @@ const {
 
 const { toASCII } = require('internal/idna');
 const { encodeStr, hexTable } = require('internal/querystring');
+const querystring = require('querystring');
 
 const {
   ERR_INVALID_ARG_TYPE
@@ -148,9 +149,6 @@ const {
   CHAR_AT,
 } = require('internal/constants');
 
-// Lazy loaded for startup performance.
-let querystring;
-
 function urlParse(url, parseQueryString, slashesDenoteHost) {
   if (url instanceof Url) return url;
 
@@ -256,7 +254,6 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
       if (simplePath[2]) {
         this.search = simplePath[2];
         if (parseQueryString) {
-          if (querystring === undefined) querystring = require('querystring');
           this.query = querystring.parse(this.search.slice(1));
         } else {
           this.query = this.search.slice(1);
@@ -445,7 +442,6 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
       this.query = rest.slice(questionIdx + 1, hashIdx);
     }
     if (parseQueryString) {
-      if (querystring === undefined) querystring = require('querystring');
       this.query = querystring.parse(this.query);
     }
   } else if (parseQueryString) {
@@ -610,7 +606,6 @@ Url.prototype.format = function format() {
   }
 
   if (this.query !== null && typeof this.query === 'object') {
-    if (querystring === undefined) querystring = require('querystring');
     query = querystring.stringify(this.query);
   }
 

diff --git a/test/parallel/test-bootstrap-modules.js b/test/parallel/test-bootstrap-modules.js
@@ -116,6 +116,7 @@ const expectedModules = new Set([
   'NativeModule internal/blob',
   'NativeModule async_hooks',
   'NativeModule path',
+  'NativeModule querystring',
   'NativeModule stream',
   'NativeModule stream/promises',
   'NativeModule string_decoder',