Skip to content

Commit

Permalink
tools: use Ubuntu 22.04 and Clang on GitHub actions
Browse files Browse the repository at this point in the history
This puts us closer to what V8 really supports.
GCC is still covered a lot by Jenkins CI.
  • Loading branch information
targos committed Jun 3, 2024
1 parent 8c5c2c1 commit 4c9cf5d
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 13 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/build-tarball.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,16 @@ concurrency:
env:
PYTHON_VERSION: '3.12'
FLAKY_TESTS: keep_retrying
CC: clang
CXX: clang++

permissions:
contents: read

jobs:
build-tarball:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
with:
Expand All @@ -63,7 +65,7 @@ jobs:
path: tarballs
test-tarball-linux:
needs: build-tarball
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
with:
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/coverage-linux-without-intl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,16 @@ concurrency:
env:
PYTHON_VERSION: '3.12'
FLAKY_TESTS: keep_retrying
CC: clang
CXX: clang++

permissions:
contents: read

jobs:
coverage-linux-without-intl:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
with:
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/coverage-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,16 @@ concurrency:
env:
PYTHON_VERSION: '3.12'
FLAKY_TESTS: keep_retrying
CC: clang
CXX: clang++

permissions:
contents: read

jobs:
coverage-linux:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ on:

env:
NODE_VERSION: lts/*
CC: clang
CXX: clang++

permissions:
contents: read

jobs:
build-lto:
runs-on: ubuntu-latest
# not working on gcc-8 and gcc-9 see https://github.com/nodejs/node/issues/38570
container: gcc:11
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
with:
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/test-internet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,16 @@ concurrency:
env:
PYTHON_VERSION: '3.12'
FLAKY_TESTS: keep_retrying
CC: clang
CXX: clang++

permissions:
contents: read

jobs:
test-internet:
if: github.repository == 'nodejs/node' || github.event_name != 'schedule'
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
with:
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/test-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,17 @@ concurrency:
env:
PYTHON_VERSION: '3.12'
FLAKY_TESTS: keep_retrying
CC: sccache clang
CXX: sccache clang++
SCCACHE_GHA_ENABLED: 'true'

permissions:
contents: read

jobs:
test-linux:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
env:
CC: sccache gcc
CXX: sccache g++
SCCACHE_GHA_ENABLED: 'true'
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
with:
Expand Down

0 comments on commit 4c9cf5d

Please sign in to comment.