fixup! src: add a condition if the argument of DomainToUnicode is e…

…mpty
nodejs · Aug 12, 2023 · 4e380fd · 4e380fd
1 parent 78b721d
commit 4e380fd
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -101,8 +101,7 @@ void BindingData::DomainToUnicode(const FunctionCallbackInfo<Value>& args) {
 
   std::string input = Utf8Value(env->isolate(), args[0]).ToString();
   if (input.empty()) {
-    return args.GetReturnValue().Set(
-        String::NewFromUtf8(env->isolate(), "").ToLocalChecked());
+    return args.GetReturnValue().Set(FIXED_ONE_BYTE_STRING(env->isolate(), ""));
   }
 
   // It is important to have an initial value that contains a special scheme.