Skip to content

Commit

Permalink
build: fix vcbuild error for missing Visual Studio
Browse files Browse the repository at this point in the history
The previous error was wrongly redirecting users
to the ICU installation steps, which is unrelated to
missing Visual Studio.

PR-URL: #32658
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
  • Loading branch information
Hakerh400 authored and addaleax committed Apr 27, 2020
1 parent 684a81d commit 4e87973
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion vcbuild.bat
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ goto msbuild-found
:msbuild-not-found
echo Failed to find a suitable Visual Studio installation.
echo Try to run in a "Developer Command Prompt" or consult
echo https://github.com/nodejs/node/blob/master/BUILDING.md#windows-1
echo https://github.com/nodejs/node/blob/master/BUILDING.md#windows
goto exit

:msbuild-found
Expand Down

0 comments on commit 4e87973

Please sign in to comment.