Skip to content

Commit

Permalink
tls: re-enable .writev() on TLSWrap
Browse files Browse the repository at this point in the history
Fix the `parallel/test-tls-over-http-tunnel.js` on Windows by
re-enabling the accidentally disabled `.writev()` method on TLSWrap.

It appears that there is some subtle issue with shutdown timing and it
manifests itself when the chunks are written in separate packets. This
leads to concurrent `shutdown`/`destroy`, which breaks the test.

PR-URL: #1155
Reviewed-By: Bert Belder <bertbelder@gmail.com>
  • Loading branch information
indutny committed Mar 15, 2015
1 parent e90ed79 commit 4eb8810
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/tls_wrap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -827,7 +827,7 @@ void TLSWrap::Initialize(Handle<Object> target,
env->SetProtoMethod(t, "enableSessionCallbacks", EnableSessionCallbacks);
env->SetProtoMethod(t, "enableHelloParser", EnableHelloParser);

StreamBase::AddMethods<TLSWrap>(env, t);
StreamBase::AddMethods<TLSWrap>(env, t, StreamBase::kFlagHasWritev);
SSLWrap<TLSWrap>::AddMethods(env, t);

#ifdef SSL_CTRL_SET_TLSEXT_SERVERNAME_CB
Expand Down

0 comments on commit 4eb8810

Please sign in to comment.