Refactor socket add logic

nodejs · Jan 27, 2020 · 4ef4a2d · 4ef4a2d
1 parent 9cd73fb
commit 4ef4a2d
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/lib/_http_agent.js b/lib/_http_agent.js
@@ -112,11 +112,12 @@ function Agent(options) {
         if (this.sockets[name])
           count += this.sockets[name].length;
 
-        if (count > this.maxSockets) {
-          socket.destroy();
-        } else if (this.keepSocketAlive(socket)) {
+        if (this.keepSocketAlive(socket) &&
+            this.maxFreeSockets > 0 &&
+            count <= this.maxSockets) {
           if (freeLen >= this.maxFreeSockets) {
-            this.freeSockets[name].shift().destroy();
+            const oldest = this.freeSockets[name].shift();
+            oldest.destroy();
           } else {
             freeSockets = freeSockets || [];
             this.freeSockets[name] = freeSockets;