Skip to content

Commit

Permalink
test: don't assume broadcast traffic is unfiltered
Browse files Browse the repository at this point in the history
parallel/test-dgram-broadcast-multi-process assumes non-local broadcast
traffic is unfiltered, an assumption that fails with, for example, the
default Fedora firewall rules.  Use a loopback interface instead.

Fixes: #219
PR-URL: #220
Reviewed-By: Fedor Indutny <fedor@indutny.com>
  • Loading branch information
bnoordhuis committed Jan 6, 2015
1 parent eaed2a1 commit 52e600a
Showing 1 changed file with 2 additions and 16 deletions.
18 changes: 2 additions & 16 deletions test/parallel/test-dgram-broadcast-multi-process.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ var common = require('../common'),
assert = require('assert'),
dgram = require('dgram'),
util = require('util'),
networkInterfaces = require('os').networkInterfaces(),
Buffer = require('buffer').Buffer,
fork = require('child_process').fork,
LOCAL_BROADCAST_HOST = '255.255.255.255',
Expand All @@ -35,19 +34,6 @@ var common = require('../common'),
new Buffer('Fourth message to send')
];

// take the first non-internal interface as the address for binding
get_bindAddress: for (var name in networkInterfaces) {
var interfaces = networkInterfaces[name];
for(var i = 0; i < interfaces.length; i++) {
var localInterface = interfaces[i];
if (!localInterface.internal && localInterface.family === 'IPv4') {
var bindAddress = localInterface.address;
break get_bindAddress;
}
}
}
assert.ok(bindAddress);

if (process.argv[2] !== 'child') {
var workers = {},
listeners = 3,
Expand Down Expand Up @@ -164,7 +150,7 @@ if (process.argv[2] !== 'child') {

// bind the address explicitly for sending
// INADDR_BROADCAST to only one interface
sendSocket.bind(common.PORT, bindAddress);
sendSocket.bind(common.PORT, '127.0.0.1');
sendSocket.on('listening', function () {
sendSocket.setBroadcast(true);
});
Expand Down Expand Up @@ -211,7 +197,7 @@ if (process.argv[2] === 'child') {

listenSocket.on('message', function(buf, rinfo) {
// receive udp messages only sent from parent
if (rinfo.address !== bindAddress) return;
if (rinfo.address !== '127.0.0.1') return;

console.error('[CHILD] %s received %s from %j',
process.pid,
Expand Down

0 comments on commit 52e600a

Please sign in to comment.