Skip to content

Commit

Permalink
test: pass env vars through to test-benchmark-http
Browse files Browse the repository at this point in the history
Allows NODE_TEST_DIR to be set (necessary to avoid path length issues
with common.PIPE).

PR-URL: #13390
Refs: #12708 (comment)
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information
gibfahn authored and jasnell committed Jun 7, 2017
1 parent 61eb085 commit 54ae7d8
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion test/sequential/test-benchmark-http.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ const path = require('path');

const runjs = path.join(__dirname, '..', '..', 'benchmark', 'run.js');

const env = Object.assign({}, process.env,
{ NODEJS_BENCHMARK_ZERO_ALLOWED: 1 });

const child = fork(runjs, ['--set', 'benchmarker=test-double',
'--set', 'c=1',
'--set', 'chunks=0',
Expand All @@ -28,7 +31,7 @@ const child = fork(runjs, ['--set', 'benchmarker=test-double',
'--set', 'len=1',
'--set', 'n=1',
'http'],
{env: {NODEJS_BENCHMARK_ZERO_ALLOWED: 1}});
{env});
child.on('exit', (code, signal) => {
assert.strictEqual(code, 0);
assert.strictEqual(signal, null);
Expand Down

0 comments on commit 54ae7d8

Please sign in to comment.