test: increase coverage of buffer

nodejs · Feb 15, 2017 · 5b1fe0c · 5b1fe0c
1 parent 2f1ce29
commit 5b1fe0c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/test/parallel/test-buffer-compare-offset.js b/test/parallel/test-buffer-compare-offset.js
@@ -11,6 +11,7 @@ assert.strictEqual(-1, a.compare(b));
 // Equivalent to a.compare(b).
 assert.strictEqual(-1, a.compare(b, 0));
 assert.strictEqual(-1, a.compare(b, '0'));
+assert.strictEqual(-1, a.compare(b, undefined));
 
 // Equivalent to a.compare(b).
 assert.strictEqual(-1, a.compare(b, 0, undefined, 0));
@@ -63,5 +64,6 @@ assert.throws(() => a.compare(b, 0, 1, 0, 100), oor);
 assert.throws(() => a.compare(b, -1), oor);
 assert.throws(() => a.compare(b, 0, '0xff'), oor);
 assert.throws(() => a.compare(b, 0, Infinity), oor);
+assert.throws(() => a.compare(b, 0, 1, -1), oor);
 assert.throws(() => a.compare(b, -Infinity, Infinity), oor);
 assert.throws(() => a.compare(), /Argument must be a Buffer/);
diff --git a/test/parallel/test-buffer-write-noassert.js b/test/parallel/test-buffer-write-noassert.js
@@ -20,6 +20,17 @@ function write(funx, args, result, res) {
     );
   }
 
+  {
+    const error = /Int/.test(funx) ?
+      /^TypeError: "buffer" argument must be a Buffer instance$/ :
+      /^TypeError: argument should be a Buffer$/;
+
+    assert.throws(
+      () => Buffer.alloc(9)[funx].apply(new Uint32Array(1), args),
+      error
+    );
+  }
+
   {
     const buf2 = Buffer.alloc(9);
     assert.strictEqual(buf2[funx](...args, true), result);