set max options.timaout accepted value to TIMEOUT_MAX

nodejs · Jul 17, 2022 · 5d2b348 · 5d2b348
1 parent 17ede2d
commit 5d2b348
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
@@ -140,10 +140,8 @@ class Test extends AsyncResource {
     }
 
     if (timeout != null && timeout !== Infinity) {
-      validateNumber(timeout, 'options.timeout', 0);
-      if (timeout < TIMEOUT_MAX) {
-        this.timeout = timeout;
-      }
+      validateNumber(timeout, 'options.timeout', 0, TIMEOUT_MAX);
+      this.timeout = timeout;
     }
 
     if (testOnlyFlag && !this.only) {

diff --git a/test/parallel/test-runner-option-validation.js b/test/parallel/test-runner-option-validation.js
@@ -6,10 +6,10 @@ const test = require('node:test');
 [Symbol(), {}, [], () => {}, 1n, true, '1'].forEach((timeout) => {
   assert.throws(() => test({ timeout }), { code: 'ERR_INVALID_ARG_TYPE' });
 });
-[-1, -Infinity, NaN].forEach((timeout) => {
+[-1, -Infinity, NaN, 2 ** 33, Number.MAX_SAFE_INTEGER].forEach((timeout) => {
   assert.throws(() => test({ timeout }), { code: 'ERR_OUT_OF_RANGE' });
 });
-[null, undefined, Infinity, 0, 1, 1.1, 2 ** 33].forEach((timeout) => {
+[null, undefined, Infinity, 0, 1, 1.1].forEach((timeout) => {
   // Valid values should not throw.
   test({ timeout });
 });