Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PR-URL: #32657 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
- Loading branch information
5e807c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would ask that we (on the project) edit the commit message when landing to make them more useful. Given the small nature of the change, this one is acceptable but it would be better as something like this:
doc: add missing brackets to sample code in esm.md
(Also, pull-requests.md says the first word needs to be an imperative verb, so please let's enforce that too or else change our docs.)
5e807c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that @Trott
Is there a way that we could lint for the imperative verb with
git node land
? I was unaware of that particular rule and saw green ingit node land
Obviously could have done a better job on the message as a whole (already had added subsystem when landing)
5e807c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not reliably, and I think people will be more annoyed by that being unreliable than I will be by the commit message here and there that doesn't match it. Honestly, I've wondered if we should remove that requirement, or at least turn it into a recommendation. I understand why it's there, but we just aren't that rigorous with our changelog messages, so it might be pointless.