Skip to content

Commit

Permalink
build: use shorthand lint target from test
Browse files Browse the repository at this point in the history
Instead of invoking jslint/cpplint from the test target,
call on the generic lint instead since it checks if eslint
exists. Since our tarballs lacks eslint we now get a more graceful
exit from `make test` instead of a traceback from jslint.

PR-URL: #6406
Fixes: #6408
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
jbergstroem committed Apr 30, 2016
1 parent c1f2df9 commit 62c31fe
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,9 @@ v8:
$(MAKE) -C deps/v8 $(V8_ARCH) $(V8_BUILD_OPTIONS)

test: | cctest # Depends on 'all'.
$(PYTHON) tools/test.py --mode=release doctool message parallel sequential -J
$(MAKE) jslint
$(MAKE) cpplint
$(PYTHON) tools/test.py --mode=release -J \
doctool message parallel sequential
$(MAKE) lint

test-parallel: all
$(PYTHON) tools/test.py --mode=release parallel -J
Expand Down

0 comments on commit 62c31fe

Please sign in to comment.