Skip to content

Commit

Permalink
test: define SharedArrayBuffer as a known global
Browse files Browse the repository at this point in the history
This commit defines SharedArrayBuffer as a global for all tests,
rather than adding comments to individual tests.

PR-URL: #20849
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
  • Loading branch information
cjihrig authored and addaleax committed May 21, 2018
1 parent 32873c5 commit 680a171
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 4 deletions.
1 change: 1 addition & 0 deletions test/.eslintrc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,4 @@ globals:
WebAssembly: false
BigInt64Array: false
BigUint64Array: false
SharedArrayBuffer: false
1 change: 0 additions & 1 deletion test/parallel/test-buffer-sharedarraybuffer.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* global SharedArrayBuffer */
'use strict';

require('../common');
Expand Down
2 changes: 0 additions & 2 deletions test/parallel/test-util-format-shared-arraybuffer.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,5 @@
require('../common');
const assert = require('assert');
const util = require('util');

/* global SharedArrayBuffer */
const sab = new SharedArrayBuffer(4);
assert.strictEqual(util.format(sab), 'SharedArrayBuffer { byteLength: 4 }');
1 change: 0 additions & 1 deletion test/parallel/test-util-types.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// Flags: --harmony-bigint --experimental-vm-modules
/* global SharedArrayBuffer */
'use strict';
const common = require('../common');
const fixtures = require('../common/fixtures');
Expand Down

0 comments on commit 680a171

Please sign in to comment.