Skip to content

Commit

Permalink
test: remove unref in http2 test
Browse files Browse the repository at this point in the history
The bug referenced in this TODO was fixed and this test no longer
requires this code to pass.

PR-URL: #21145
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
apapirovski committed Jun 7, 2018
1 parent 5012587 commit 6858ab5
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions test/parallel/test-stream-pipeline.js
Original file line number Diff line number Diff line change
Expand Up @@ -281,12 +281,6 @@ common.crashOnUnhandledRejection();
});

pipeline(rs, req, common.mustCall((err) => {
// TODO: this is working around an http2 bug
// where the client keeps the event loop going
// (replacing the rs.destroy() with req.end()
// exits it so seems to be a destroy bug there
client.unref();

server.close();
client.close();
}));
Expand Down

0 comments on commit 6858ab5

Please sign in to comment.