Skip to content

Commit

Permalink
test: add an exception test to http-write-head
Browse files Browse the repository at this point in the history
* Add an exception test.
* Add `common.mustCall()`.
* Make use of Arrow function.

PR-URL: #11034
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
hiroppy authored and jasnell committed Mar 8, 2017
1 parent 07610f6 commit 6cc0db8
Showing 1 changed file with 16 additions and 11 deletions.
27 changes: 16 additions & 11 deletions test/parallel/test-http-write-head.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
'use strict';
require('../common');
var assert = require('assert');
var http = require('http');
const common = require('../common');
const assert = require('assert');
const http = require('http');

// Verify that ServerResponse.writeHead() works as setHeader.
// Issue 5036 on github.

var s = http.createServer(function(req, res) {
const s = http.createServer(common.mustCall((req, res) => {
res.setHeader('test', '1');

// toLowerCase() is used on the name argument, so it must be a string.
Expand All @@ -31,18 +31,23 @@ var s = http.createServer(function(req, res) {
assert.ok(threw, 'Undefined value should throw');

res.writeHead(200, { Test: '2' });

assert.throws(() => {
res.writeHead(100, {});
}, /^Error: Can't render headers after they are sent to the client$/);

res.end();
});
}));

s.listen(0, runTest);
s.listen(0, common.mustCall(runTest));

function runTest() {
http.get({ port: this.address().port }, function(response) {
response.on('end', function() {
assert.equal(response.headers['test'], '2');
http.get({ port: this.address().port }, common.mustCall((response) => {
response.on('end', common.mustCall(() => {
assert.strictEqual(response.headers['test'], '2');
assert.notStrictEqual(response.rawHeaders.indexOf('Test'), -1);
s.close();
});
}));
response.resume();
});
}));
}

0 comments on commit 6cc0db8

Please sign in to comment.