Skip to content

Commit

Permalink
deps: V8: cherry-pick 3e4952cb2a59
Browse files Browse the repository at this point in the history
Original commit message:

    [test] fix uninitialized error

    In op1a.Equals(&op3) call, that->parameter() is undefined.
    which triggers uninitialized error from gcc.

    Change-Id: I87f1fcba3e57adbb5a1e745a3d787c62a87fd1d3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4307714
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#86267}

Refs: v8/v8@3e4952c
PR-URL: #47236
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
richardlau authored and RafaelGSS committed Apr 5, 2023
1 parent f80697d commit 70e2839
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.11',
'v8_embedder_string': '-node.12',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/test/cctest/compiler/test-operator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ TEST(TestOperator1double_Equals) {
CHECK(!op2b.Equals(&op1a));
CHECK(!op2b.Equals(&op1b));

Operator op3(25, NONE, "Weepy", 0, 0, 0, 0, 0, 0);
Operator1<double> op3(25, NONE, "Weepy", 0, 0, 0, 0, 0, 0, 1.1);

CHECK(!op1a.Equals(&op3));
CHECK(!op1b.Equals(&op3));
Expand Down

0 comments on commit 70e2839

Please sign in to comment.