Skip to content

Commit

Permalink
fixup! deps: fix V8 compilation on GCC 12
Browse files Browse the repository at this point in the history
Co-authored-by: Richard Lau <rlau@redhat.com>
  • Loading branch information
joyeecheung and richardlau authored Jul 5, 2024
1 parent 373864b commit 75a4d43
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deps/v8/src/base/macros.h
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ namespace base {
// base::is_trivially_copyable will differ for these cases.
template <typename T>
struct is_trivially_copyable {
#if V8_CC_MSVC || (__GNUC__ == 12 && __GNUC_MINOR__ < 2)
#if V8_CC_MSVC || (__GNUC__ == 12 && __GNUC_MINOR__ <= 2)
// Unfortunately, MSVC 2015 is broken in that std::is_trivially_copyable can
// be false even though it should be true according to the standard.
// (status at 2018-02-26, observed on the msvc waterfall bot).
Expand Down

0 comments on commit 75a4d43

Please sign in to comment.