Skip to content

Commit

Permalink
test: enhance fs-watch-recursive test
Browse files Browse the repository at this point in the history
This patch

  - issues a TAP plugin parsable message on non darwin/windows boxes
  - uses `const` wherever applicable
  - moves the test to parallel

PR-URL: #2599
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
thefourtheye authored and Myles Borins committed Nov 16, 2015
1 parent 44d4a02 commit 75b4613
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 51 deletions.
43 changes: 43 additions & 0 deletions test/parallel/test-fs-watch-recursive.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
'use strict';

const common = require('../common');

if (!(process.platform === 'darwin' || common.isWindows)) {
console.log('1..0 # Skipped: recursive option is darwin/windows specific');
return;
}

const assert = require('assert');
const path = require('path');
const fs = require('fs');

const testDir = common.tmpDir;
const filenameOne = 'watch.txt';
const testsubdirName = 'testsubdir';
const testsubdir = path.join(testDir, testsubdirName);
const relativePathOne = path.join('testsubdir', filenameOne);
const filepathOne = path.join(testsubdir, filenameOne);

common.refreshTmpDir();

fs.mkdirSync(testsubdir, 0o700);

const watcher = fs.watch(testDir, {recursive: true});

var watcherClosed = false;
watcher.on('change', function(event, filename) {
assert.ok('change' === event || 'rename' === event);

// Ignore stale events generated by mkdir and other tests
if (filename !== relativePathOne)
return;

watcher.close();
watcherClosed = true;
});

fs.writeFileSync(filepathOne, 'world');

process.on('exit', function() {
assert(watcherClosed, 'watcher Object was not closed');
});
51 changes: 0 additions & 51 deletions test/sequential/test-fs-watch-recursive.js

This file was deleted.

0 comments on commit 75b4613

Please sign in to comment.