Skip to content

Commit

Permalink
deps: revert whitespace changes on V8
Browse files Browse the repository at this point in the history
While landing some of the V8 upgrades on the v12 branch, something went
wrong and git made unecessary (and incorrect) whitespace changes to test
fixtures, which broke V8 tests. This was likely caused by the use of
`git node land` or a simiar tool. Revert those changes to fix our tests.
Since this only reverts unwanted changes on deps/v8, and it only affects
tests, don't bump v8_embedder_string.

PR-URL: #32605
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
  • Loading branch information
mmarchini authored and MylesBorins committed Apr 2, 2020
1 parent f58594b commit 784df12
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ snippet: "
class A {
get #a() { return 1; }
set #a(val) { }

constructor() {
this.#a++;
this.#a = 1;
Expand Down Expand Up @@ -189,3 +189,4 @@ constant pool: [
]
handlers: [
]

Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ snippet: "
get #d() { return 1; }
set #d(val) { }
}

class E extends D {
get #e() { return 2; }
set #e(val) { }
Expand Down Expand Up @@ -395,3 +395,4 @@ constant pool: [
]
handlers: [
]

Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ snippet: "
#a() { return 1; }
constructor() { return this.#a(); }
}

var test = A;
new A;
"
Expand Down Expand Up @@ -44,7 +44,7 @@ snippet: "
#b() { return 1; }
constructor() { this.#b = 1; }
}

var test = B;
new test;
"
Expand Down Expand Up @@ -76,7 +76,7 @@ snippet: "
#c() { return 1; }
constructor() { this.#c++; }
}

var test = C;
new test;
"
Expand All @@ -101,3 +101,4 @@ constant pool: [
]
handlers: [
]

Original file line number Diff line number Diff line change
Expand Up @@ -195,3 +195,4 @@ constant pool: [
]
handlers: [
]

0 comments on commit 784df12

Please sign in to comment.