Skip to content

Commit

Permalink
src: describe what NODE_MODULE_VERSION is for
Browse files Browse the repository at this point in the history
Current comment described what to do with it when the ABI changes, but
implied that Node.js would load modules with newer ABI numbers, which it
will not.

PR-URL: #10414
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information
sam-github authored and MylesBorins committed Jan 23, 2017
1 parent 0ea78d4 commit 78d85c6
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/node_version.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@
(minor) == NODE_MINOR_VERSION && (patch) <= NODE_PATCH_VERSION))

/**
* Node.js will refuse to load modules that weren't compiled against its own
* module ABI number, exposed as the process.versions.modules property.
*
* When this version number is changed, node.js will refuse
* to load older modules. This should be done whenever
* an API is broken in the C++ side, including in v8 or
Expand Down

0 comments on commit 78d85c6

Please sign in to comment.