Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Currently, the punycode module is used in exactly one spot within core (the url parser). With the recent switch to using the much faster ICU based punycode implementation by default, the punycode module is now only used when node happens to be built without icu. This change moves the punycode module into internal and hard deprecates `require('punycode')`. The hard deprecation notice is only printed in ICU builds. When the new WHATWG URL implementation lands, users will have access to the URL.domainToUnicode() and URL.domainToASCII statics that are defined as part of the standard interface. The next step (in the next major) is to make it so that internal/punycode.js is only included if the Node.js binary is built without ICU.
- Loading branch information