deps: V8: add explicit constructor to CppHeapCreateParams

Co-authored-by: Jiawen Geng <technicalcute@gmail.com>
nodejs · Jan 1, 2023 · 7c876bd · 7c876bd
1 parent 50744bb
commit 7c876bd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/common.gypi b/common.gypi
@@ -36,7 +36,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.7',
+    'v8_embedder_string': '-node.8',
 
     ##### V8 defaults for Node.js #####
 

diff --git a/deps/v8/include/v8-cppgc.h b/deps/v8/include/v8-cppgc.h
@@ -77,6 +77,11 @@ struct WrapperDescriptor final {
 };
 
 struct V8_EXPORT CppHeapCreateParams {
+  CppHeapCreateParams(
+            std::vector<std::unique_ptr<cppgc::CustomSpaceBase>> custom_spaces,
+            WrapperDescriptor wrapper_descriptor)
+            : custom_spaces(std::move(custom_spaces)),
+              wrapper_descriptor(wrapper_descriptor) {}
   CppHeapCreateParams(const CppHeapCreateParams&) = delete;
   CppHeapCreateParams& operator=(const CppHeapCreateParams&) = delete;