Skip to content

Commit

Permalink
test: improve test-fs-empty-readStream.js
Browse files Browse the repository at this point in the history
* use const instead of var
* use common.mustCall to control functions execution
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: #10479
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
  • Loading branch information
edsadr authored and MylesBorins committed Jan 24, 2017
1 parent 350ca0f commit 7d92dd6
Showing 1 changed file with 16 additions and 16 deletions.
32 changes: 16 additions & 16 deletions test/parallel/test-fs-empty-readStream.js
Original file line number Diff line number Diff line change
@@ -1,38 +1,38 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var path = require('path');
var fs = require('fs');
const common = require('../common');
const assert = require('assert');
const path = require('path');
const fs = require('fs');

var emptyFile = path.join(common.fixturesDir, 'empty.txt');
const emptyFile = path.join(common.fixturesDir, 'empty.txt');

fs.open(emptyFile, 'r', function(error, fd) {
fs.open(emptyFile, 'r', common.mustCall((error, fd) => {
assert.ifError(error);

var read = fs.createReadStream(emptyFile, { 'fd': fd });
const read = fs.createReadStream(emptyFile, { 'fd': fd });

read.once('data', function() {
read.once('data', () => {
throw new Error('data event should not emit');
});

read.once('end', common.mustCall(function endEvent1() {}));
});
}));

fs.open(emptyFile, 'r', function(error, fd) {
fs.open(emptyFile, 'r', common.mustCall((error, fd) => {
assert.ifError(error);

var read = fs.createReadStream(emptyFile, { 'fd': fd });
const read = fs.createReadStream(emptyFile, { 'fd': fd });
read.pause();

read.once('data', function() {
read.once('data', () => {
throw new Error('data event should not emit');
});

read.once('end', function endEvent2() {
throw new Error('end event should not emit');
});

setTimeout(function() {
assert.equal(read.isPaused(), true);
}, common.platformTimeout(50));
});
setTimeout(common.mustCall(() => {
assert.strictEqual(read.isPaused(), true);
}), common.platformTimeout(50));
}));

0 comments on commit 7d92dd6

Please sign in to comment.