Skip to content

Commit

Permalink
lib,test: remove lib/internal/test/unicode.js
Browse files Browse the repository at this point in the history
Remove lib/internal/test/unicode.js and associated test. When we added
the file and test, only comments in lib had non-ASCII characters. Now,
lib/internal/cli_table.js has non-ASCII characters. Tests that exercise
the `console.table()` therefore fulfill the need to test non-ASCII
characters in built-in modules.

PR-URL: #25298
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott committed Jan 3, 2019
1 parent aea5229 commit 7e15f04
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 21 deletions.
6 changes: 6 additions & 0 deletions lib/internal/cli_table.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ const { Buffer } = require('buffer');
const { removeColors } = require('internal/util');
const HasOwnProperty = Function.call.bind(Object.prototype.hasOwnProperty);

// The use of Unicode characters below is the only non-comment use of non-ASCII
// Unicode characters in Node.js built-in modules. If they are ever removed or
// rewritten with \u escapes, then a test will need to be (re-)added to Node.js
// core to verify that Unicode characters work in built-ins. Otherwise,
// consumers using Unicode in _third_party_main.js will run into problems.
// Refs: https://github.com/nodejs/node/issues/10673
const tableChars = {
/* eslint-disable node-core/non-ascii-character */
middleMiddle: '─',
Expand Down
8 changes: 0 additions & 8 deletions lib/internal/test/unicode.js

This file was deleted.

1 change: 0 additions & 1 deletion node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@
'lib/internal/socket_list.js',
'lib/internal/test/binding.js',
'lib/internal/test/heap.js',
'lib/internal/test/unicode.js',
'lib/internal/timers.js',
'lib/internal/tls.js',
'lib/internal/trace_events_async_hooks.js',
Expand Down
12 changes: 0 additions & 12 deletions test/parallel/test-internal-unicode.js

This file was deleted.

0 comments on commit 7e15f04

Please sign in to comment.