Skip to content

Commit

Permalink
doc: remove unnecessary "obvious(ly)" modifiers in esm.md
Browse files Browse the repository at this point in the history
Remove "obvious" and "obviously" in two places in esm.md. It may be
obvious to some, but likely not everyone or else it probably wouldn't be
worth mentioning/documenting.

PR-URL: #32457
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
  • Loading branch information
Trott authored and MylesBorins committed Mar 26, 2020
1 parent bdfbbf6 commit 7e43813
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions doc/api/esm.md
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ would be usable by any version of Node.js, since `import` can refer to CommonJS
files; but it would not provide any of the advantages of using ES module syntax.

A package could also switch from CommonJS to ES module syntax in a breaking
change version bump. This has the obvious disadvantage that the newest version
change version bump. This has the disadvantage that the newest version
of the package would only be usable in ES module-supporting versions of Node.js.

Every pattern has tradeoffs, but there are two broad approaches that satisfy the
Expand Down Expand Up @@ -1341,7 +1341,7 @@ JavaScript using the [`transformSource` hook][]. Before that hook gets called,
however, other hooks need to tell Node.js not to throw an error on unknown file
types; and to tell Node.js how to load this new file type.

This is obviously less performant than transpiling source files before running
This is less performant than transpiling source files before running
Node.js; a transpiler loader should only be used for development and testing
purposes.

Expand Down

0 comments on commit 7e43813

Please sign in to comment.