fixup! fs: improve error performance of chownSync

nodejs · Sep 26, 2023 · 8437da5 · 8437da5
1 parent a38a542
commit 8437da5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/benchmark/fs/bench-chownSync.js b/benchmark/fs/bench-chownSync.js
@@ -5,6 +5,11 @@ const fs = require('fs');
 const tmpdir = require('../../test/common/tmpdir');
 tmpdir.refresh();
 
+// Windows does not have `getuid` or `getgid`.
+if (process.platform === 'win32') {
+  return;
+}
+
 const tmpfile = tmpdir.resolve(`.existing-file-${process.pid}`);
 fs.writeFileSync(tmpfile, 'this-is-for-a-benchmark', 'utf8');
 

diff --git a/src/node_file.cc b/src/node_file.cc
@@ -2768,7 +2768,7 @@ static void ChownSync(const FunctionCallbackInfo<Value>& args) {
   const uv_gid_t gid = static_cast<uv_gid_t>(args[2].As<Integer>()->Value());
 
   uv_fs_t req;
-  auto make = OnScopeLeave([&req]() { uv_fs_req_cleanup(&req); });
+  auto cleanup = OnScopeLeave([&req]() { uv_fs_req_cleanup(&req); });
   FS_SYNC_TRACE_BEGIN(chown);
   int err = uv_fs_chown(nullptr, &req, *path, uid, gid, nullptr);
   FS_SYNC_TRACE_END(chown);