[Squash] Fixups

nodejs · Jun 28, 2021 · 89c1895 · 89c1895
1 parent ed2f701
commit 89c1895
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/lib/internal/webstreams/adapters.js b/lib/internal/webstreams/adapters.js
@@ -465,9 +465,12 @@ function newStreamReadableFromReadableStream(readableStream, options = {}) {
       PromisePrototypeThen(
         reader.read(),
         (chunk) => {
-          readable.push(chunk.value);
-          if (chunk.done)
+          if (chunk.done) {
+            // Value should always be undefined here.
             readable.push(null);
+          } else {
+            readable.push(chunk.value);
+          }
         },
         (error) => readable.destroy(error));
     },
@@ -667,9 +670,11 @@ function newStreamDuplexFromReadableWritablePair(pair = {}, options = {}) {
       PromisePrototypeThen(
         reader.read(),
         (chunk) => {
-          duplex.push(chunk.value);
-          if (chunk.done)
+          if (chunk.done) {
             duplex.push(null);
+          } else {
+            duplex.push(chunk.value);
+          }
         },
         (error) => duplex.destroy(error));
     },