-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
http2: check if stream is not destroyed before sending trailers
Fixes: #22855 PR-URL: #22896 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
- Loading branch information
Showing
2 changed files
with
50 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
const { mustCall } = common; | ||
|
||
if (!common.hasCrypto) | ||
common.skip('missing crypto'); | ||
|
||
const http2 = require('http2'); | ||
const assert = require('assert'); | ||
|
||
const { | ||
HTTP2_HEADER_PATH, | ||
HTTP2_HEADER_METHOD, | ||
} = http2.constants; | ||
|
||
// This tests verifies that calling `req.socket.destroy()` via | ||
// setImmediate does not crash. | ||
// Fixes https://github.com/nodejs/node/issues/22855. | ||
|
||
const app = http2.createServer(mustCall((req, res) => { | ||
res.end('hello'); | ||
setImmediate(() => req.socket.destroy()); | ||
})); | ||
|
||
app.listen(0, mustCall(() => { | ||
const session = http2.connect(`http://localhost:${app.address().port}`); | ||
const request = session.request({ | ||
[HTTP2_HEADER_PATH]: '/', | ||
[HTTP2_HEADER_METHOD]: 'get' | ||
}); | ||
request.once('response', mustCall((headers, flags) => { | ||
let data = ''; | ||
request.on('data', (chunk) => { data += chunk; }); | ||
request.on('end', mustCall(() => { | ||
assert.strictEqual(data, 'hello'); | ||
session.close(); | ||
app.close(); | ||
})); | ||
})); | ||
request.end(); | ||
})); |