-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
When active sockets less than or equal to max sockets limit, should keep it instead of destroy it. Example: If maxSockets = 5 and a socket:4 become free, the freeSockets list will be: before: socket:4 will be destroy freeSockets: [0], [1], [2], [3] now: socket:4 will push to the end of list freeSockets: [0], [1], [2], [3], [4]
- Loading branch information
Showing
2 changed files
with
54 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
var common = require('../common'); | ||
var assert = require('assert'); | ||
var http = require('http'); | ||
|
||
var agent = new http.Agent({ | ||
keepAlive: true, | ||
keepAliveMsecs: 1000, | ||
maxSockets: 2, | ||
maxFreeSockets: 2 | ||
}); | ||
|
||
var server = http.createServer(function(req, res) { | ||
res.end('hello world'); | ||
}); | ||
|
||
function get(path, callback) { | ||
return http.get({ | ||
host: 'localhost', | ||
port: common.PORT, | ||
agent: agent, | ||
path: path | ||
}, callback); | ||
} | ||
|
||
var count = 0; | ||
function done() { | ||
if (++count !== 2) { | ||
return; | ||
} | ||
var freepool = agent.freeSockets[Object.keys(agent.freeSockets)[0]]; | ||
assert.equal(freepool.length, 2, | ||
'expect keep 2 free sockets, but got ' + freepool.length); | ||
agent.destroy(); | ||
server.close(); | ||
} | ||
|
||
server.listen(common.PORT, function() { | ||
get('/1', function(res) { | ||
assert.equal(res.statusCode, 200); | ||
res.resume(); | ||
res.on('end', function() { | ||
process.nextTick(done); | ||
}); | ||
}); | ||
|
||
get('/2', function(res) { | ||
assert.equal(res.statusCode, 200); | ||
res.resume(); | ||
res.on('end', function() { | ||
process.nextTick(done); | ||
}); | ||
}); | ||
}); |