Skip to content

Commit

Permalink
tools: open test.tap file in write-binary mode
Browse files Browse the repository at this point in the history
By default the logfile is opened in append mode. This commit makes sure
that the file is opened in write-binary mode, so that the file will be
created if it doesn't exist or overwrite if it exists.

Fixes: #2834

PR-URL: #2837
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
  • Loading branch information
thefourtheye committed Sep 15, 2015
1 parent c70c778 commit 91e7e9c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -1418,7 +1418,7 @@ def Main():
logger.addHandler(ch)
logger.setLevel(logging.INFO)
if options.logfile:
fh = logging.FileHandler(options.logfile)
fh = logging.FileHandler(options.logfile, mode='wb')
logger.addHandler(fh)

workspace = abspath(join(dirname(sys.argv[0]), '..'))
Expand Down

0 comments on commit 91e7e9c

Please sign in to comment.