Skip to content

Commit

Permalink
build: fix mkpeephole configuration
Browse files Browse the repository at this point in the history
mkpeephole is a binary that gets generated and run at V8 build time.
On cross-compilation builds separate build toolchains are required.
Similar to want_separate_host_toolset we default to disabled.

PR-URL: #8317
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
ofrobots authored and jasnell committed Sep 29, 2016
1 parent 1a93e03 commit 94f68b5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -760,6 +760,8 @@ def configure_node(o):
want_snapshots = not options.without_snapshot
o['variables']['want_separate_host_toolset'] = int(
cross_compiling and want_snapshots)
o['variables']['want_separate_host_toolset_mkpeephole'] = int(
cross_compiling)

if target_arch == 'arm':
configure_arm(o)
Expand Down

0 comments on commit 94f68b5

Please sign in to comment.