http: set rejectNonStandardBodyWrites option default to false

nodejs · May 2, 2023 · 9c2e7da · 9c2e7da
1 parent dd8ff7b
commit 9c2e7da
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js
@@ -152,7 +152,7 @@ function OutgoingMessage(options) {
 
   this[kErrored] = null;
   this[kHighWaterMark] = options?.highWaterMark ?? getDefaultHighWaterMark();
-  this[kRejectNonStandardBodyWrites] = options?.rejectNonStandardBodyWrites ?? true;
+  this[kRejectNonStandardBodyWrites] = options?.rejectNonStandardBodyWrites ?? false;
 }
 ObjectSetPrototypeOf(OutgoingMessage.prototype, Stream.prototype);
 ObjectSetPrototypeOf(OutgoingMessage, Stream);

diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -490,7 +490,7 @@ function storeHTTPOptions(options) {
     validateBoolean(rejectNonStandardBodyWrites, 'options.rejectNonStandardBodyWrites');
     this.rejectNonStandardBodyWrites = rejectNonStandardBodyWrites;
   } else {
-    this.rejectNonStandardBodyWrites = true
+    this.rejectNonStandardBodyWrites = false
   }
 }
 

diff --git a/test/parallel/test-http-head-throw-on-response-body-write.js b/test/parallel/test-http-head-throw-on-response-body-write.js
@@ -24,17 +24,10 @@ const common = require('../common');
 const assert = require('assert');
 const http = require('http');
 
-// should be using common.mustCall on both req res callbacks provided to createServer
 {
   const server = http.createServer((req, res) => {
-    assert.throws(() => {
-      res.write('this is content');
-    }, {
-      code: 'ERR_HTTP_BODY_NOT_ALLOWED',
-      name: 'Error',
-      message: 'Adding content for this request method or response status is not allowed.'
-    });
-    res.end();
+    res.writeHead(200);
+    res.end('this is content');
   });
   server.listen(0);