Skip to content

Commit

Permalink
test: fix flaky test-http2-reset-flood
Browse files Browse the repository at this point in the history
Set `allowHalfOpen: true` in the client.

Fixes: #29802
Refs: #31806

PR-URL: #34318
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
  • Loading branch information
Trott authored and cjihrig committed Jul 22, 2020
1 parent 8023815 commit 9fa53b3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 0 additions & 4 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ prefix parallel
# sample-test : PASS,FLAKY

[true] # This section applies to all platforms
# https://github.com/nodejs/node/issues/29802
test-http2-reset-flood: PASS,FLAKY

[$system==win32]
# https://github.com/nodejs/node/issues/32863
Expand Down Expand Up @@ -46,8 +44,6 @@ test-crypto-keygen: SKIP
[$system==freebsd]
# https://github.com/nodejs/node/issues/31727
test-fs-stat-bigint: PASS,FLAKY
# https://github.com/nodejs/node/issues/29802
test-http2-reset-flood: PASS,FLAKY
# https://github.com/nodejs/node/issues/28803
test-stdout-close-catch: PASS,FLAKY
# https://github.com/nodejs/node/issues/31280
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-reset-flood.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ if (process.env.HAS_STARTED_WORKER) {
process.env.HAS_STARTED_WORKER = 1;
const worker = new Worker(__filename).on('message', common.mustCall((port) => {
const h2header = Buffer.alloc(9);
const conn = net.connect(port);
const conn = net.connect({ port, allowHalfOpen: true });

conn.write('PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n');

Expand Down

0 comments on commit 9fa53b3

Please sign in to comment.