src: fix uv_err_name memory leak

PR-URL: #44421 Refs: #44401 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
nodejs · Sep 16, 2022 · a2a6233 · a2a6233
1 parent a35b204
commit a2a6233
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/uv.cc b/src/uv.cc
@@ -73,7 +73,8 @@ void ErrName(const FunctionCallbackInfo<Value>& args) {
   int err;
   if (!args[0]->Int32Value(env->context()).To(&err)) return;
   CHECK_LT(err, 0);
-  const char* name = uv_err_name(err);
+  char name[50];
+  uv_err_name_r(err, name, sizeof(name));
   args.GetReturnValue().Set(OneByteString(env->isolate(), name));
 }
 

diff --git a/test/parallel/test-uv-errno.js b/test/parallel/test-uv-errno.js
@@ -12,6 +12,8 @@ const { internalBinding } = require('internal/test/binding');
 const uv = internalBinding('uv');
 const keys = Object.keys(uv);
 
+assert.strictEqual(uv.errname(-111111), 'Unknown system error -111111');
+
 keys.forEach((key) => {
   if (!key.startsWith('UV_'))
     return;