fs: improve ExistsSync performance

nodejs · Jun 24, 2024 · a4b05d2 · a4b05d2
1 parent d335487
commit a4b05d2
Showing 1 changed file with 5 additions and 15 deletions.
diff --git a/src/node_file.cc b/src/node_file.cc
@@ -1003,24 +1003,14 @@ static void ExistsSync(const FunctionCallbackInfo<Value>& args) {
   THROW_IF_INSUFFICIENT_PERMISSIONS(
       env, permission::PermissionScope::kFileSystemRead, path.ToStringView());
 
-  uv_fs_t req;
-  auto make = OnScopeLeave([&req]() { uv_fs_req_cleanup(&req); });
+  std::error_code error{};
   FS_SYNC_TRACE_BEGIN(access);
-  int err = uv_fs_access(nullptr, &req, path.out(), 0, nullptr);
+  bool exists = std::filesystem::exists(path.ToStringView(), error);
   FS_SYNC_TRACE_END(access);
-
-#ifdef _WIN32
-  // In case of an invalid symlink, `uv_fs_access` on win32
-  // will **not** return an error and is therefore not enough.
-  // Double check with `uv_fs_stat()`.
-  if (err == 0) {
-    FS_SYNC_TRACE_BEGIN(stat);
-    err = uv_fs_stat(nullptr, &req, path.out(), nullptr);
-    FS_SYNC_TRACE_END(stat);
+  if (error) {
+    exists = false;
   }
-#endif  // _WIN32
-
-  args.GetReturnValue().Set(err == 0);
+  args.GetReturnValue().Set(exists);
 }
 
 // Used to speed up module loading.  Returns 0 if the path refers to