test: add util.types tests

nodejs · Nov 21, 2022 · b1bf33f · b1bf33f
1 parent 7aae649
commit b1bf33f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/internal/util/types.js b/lib/internal/util/types.js
@@ -58,7 +58,7 @@ function isBigUint64Array(value) {
 }
 
 function isArrayBufferDetached(value) {
-  if (ArrayBufferPrototypeGetByteLength(value) === 0) {
+  if (value instanceof ArrayBuffer && ArrayBufferPrototypeGetByteLength(value) === 0) {
     return _isArrayBufferDetached(value);
   }
   return false;

diff --git a/test/parallel/test-util-types.js b/test/parallel/test-util-types.js
@@ -67,6 +67,15 @@ for (const [ value, _method ] of [
   }
 }
 
+// Check detached array buffers.
+{
+  [null, undefined].forEach((entry) => assert(types.isArrayBufferDetached(entry) === false));
+
+  const { buffer } = new Uint8Array([1, 2, 3]);
+  new MessageChannel().port1.postMessage('', [buffer]);
+  assert(types.isArrayBufferDetached(buffer));
+}
+
 // Check boxed primitives.
 [
   new Boolean(),