Remove stack trace for syntax error

nodejs · Jul 15, 2016 · b1dd10d · b1dd10d
1 parent 048cf6b
commit b1dd10d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/lib/repl.js b/lib/repl.js
@@ -350,16 +350,15 @@ function REPLServer(prompt,
     debug('domain error');
     const top = replMap.get(self);
     internalUtil.decorateErrorStack(e);
-    if (e.stack && self.replMode === exports.REPL_MODE_STRICT) {
+    if (e instanceof SyntaxError && e.stack) {
+      // remove repl:line-number and stack trace
+      e.stack = e.stack
+                 .replace(/^repl:\d+\r?\n/, '')
+                 .replace(/^\s+at\s.*\n?/gm, '');
+    } else if (e.stack && self.replMode === exports.REPL_MODE_STRICT) {
       e.stack = e.stack.replace(/(\s+at\s+repl:)(\d+)/,
                                 (_, pre, line) => pre + (line - 1));
     }
-    if (e instanceof SyntaxError &&
-        e.stack &&
-        !e.stack.match(/^SyntaxError:/)) {
-      // remove filename:line-number
-      e.stack = e.stack.replace(/^.*?\n/, '');
-    }
     top.outputStream.write((e.stack || e) + '\n');
     top.lineParser.reset();
     top.bufferedCommand = '';

diff --git a/test/parallel/test-repl.js b/test/parallel/test-repl.js
@@ -333,9 +333,12 @@ function error_test() {
       expect: "'node'\n" + prompt_unix },
     { client: client_unix, send: 'function name(){ return "nodejs"; };name()',
       expect: "'nodejs'\n" + prompt_unix },
-    // Avoid emitting filename:line-number for SyntaxError
+    // Avoid emitting repl:line-number for SyntaxError
     { client: client_unix, send: 'a = 3.5e',
       expect: /^(?!repl)/ },
+    // Avoid emitting stack trace
+    { client: client_unix, send: 'a = 3.5e',
+      expect: /^(?!\s+at\s)/ },
   ]);
 }