Skip to content

Commit

Permalink
build: don't clean obj.target directory if it doesn't exist
Browse files Browse the repository at this point in the history
This can happen to ninja builds, which would then throw an
error instead of being a noop if the command is executed.
  • Loading branch information
joyeecheung committed Aug 19, 2024
1 parent f0134fa commit b7221e7
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,9 @@ coverage-build-js:

.PHONY: coverage-test
coverage-test: coverage-build
$(FIND) out/$(BUILDTYPE)/obj.target -name "*.gcda" -type f -exec $(RM) {} \;
@if [ -d "out/Release/obj.target" ]; then \
$(FIND) out/$(BUILDTYPE)/obj.target -name "*.gcda" -type f -exec $(RM) {}; \
fi
-NODE_V8_COVERAGE=coverage/tmp \
TEST_CI_ARGS="$(TEST_CI_ARGS) --type=coverage" $(MAKE) $(COVTESTS)
$(MAKE) coverage-report-js
Expand Down

0 comments on commit b7221e7

Please sign in to comment.