crypto: fix scrypt keylen validation

Fixes: #38381 PR-URL: #38385 Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
nodejs · Apr 29, 2021 · c1d9b5b · c1d9b5b
1 parent 28f02cb
commit c1d9b5b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/internal/crypto/scrypt.js b/lib/internal/crypto/scrypt.js
@@ -16,6 +16,7 @@ const {
 const {
   validateCallback,
   validateInteger,
+  validateInt32,
   validateUint32,
 } = require('internal/validators');
 
@@ -90,7 +91,7 @@ function check(password, salt, keylen, options) {
 
   password = getArrayBufferOrView(password, 'password');
   salt = getArrayBufferOrView(salt, 'salt');
-  validateUint32(keylen, 'keylen');
+  validateInt32(keylen, 'keylen', 0);
 
   let { N, r, p, maxmem } = defaults;
   if (options && options !== defaults) {

diff --git a/test/parallel/test-crypto-scrypt.js b/test/parallel/test-crypto-scrypt.js
@@ -143,6 +143,10 @@ const badargs = [
     args: ['', '', -42],
     expected: { code: 'ERR_OUT_OF_RANGE', message: /"keylen"/ },
   },
+  {
+    args: ['', '', 2147485780],
+    expected: { code: 'ERR_OUT_OF_RANGE', message: /"keylen"/ },
+  },
 ];
 
 for (const options of good) {