Skip to content

Commit

Permalink
test: replace assert.equal with assert.strictEqual
Browse files Browse the repository at this point in the history
PR-URL: #18119
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
Sho Miyamoto authored and codebytere committed Aug 3, 2018
1 parent 1875ab3 commit c2ae01f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions test/es-module/test-esm-dynamic-import.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ targetURL.pathname = absolutePath;
function expectErrorProperty(result, propertyKey, value) {
Promise.resolve(result)
.catch(common.mustCall(error => {
assert.equal(error[propertyKey], value);
assert.strictEqual(error[propertyKey], value);
}));
}

Expand Down Expand Up @@ -51,7 +51,7 @@ function expectOkNamespace(result) {
function expectFsNamespace(result) {
Promise.resolve(result)
.then(common.mustCall(ns => {
assert.equal(typeof ns.default.writeFile, 'function');
assert.strictEqual(typeof ns.default.writeFile, 'function');
}));
}

Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/es-module-loaders/loader-shared-dep.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ import dep from './loader-dep.js';
import assert from 'assert';

export function resolve(specifier, base, defaultResolve) {
assert.equal(dep.format, 'esm');
assert.strictEqual(dep.format, 'esm');
return defaultResolve(specifier, base);
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export async function resolve (specifier, base, defaultResolve) {
await defaultResolve(specifier, base);
}
catch (e) {
assert.equal(e.code, 'MODULE_NOT_FOUND');
assert.strictEqual(e.code, 'MODULE_NOT_FOUND');
return {
format: 'builtin',
url: 'fs'
Expand Down

0 comments on commit c2ae01f

Please sign in to comment.