Skip to content

Commit

Permalink
doc: mention where to push security commits
Browse files Browse the repository at this point in the history
PR-URL: #44691
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
  • Loading branch information
RafaelGSS committed Sep 26, 2022
1 parent 84e654c commit c658cda
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions doc/contributing/releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,19 @@ branch.
$ git checkout -b v1.2.3-proposal upstream/v1.x-staging
```

<details>
<summary>Security release</summary>

When performing Security Releases, the `vN.x.x-proposal` branch should be
branched off of `vN.x`.

```console
$ git checkout -b v1.2.3-proposal upstream/v1.x
git cherry-pick ... # cherry-pick nodejs-private PR commits directly into the proposal
```

</details>

### 3. Update `src/node_version.h`

Set the version for the proposed release using the following macros, which are
Expand Down Expand Up @@ -458,6 +471,9 @@ Notable changes:
PR-URL: TBD
```

**Note**: Ensure to push the proposal branch to the nodejs-private repository.
Otherwise, you will leak the commits before the security release.

</details>

### 6. Propose release on GitHub
Expand Down

0 comments on commit c658cda

Please sign in to comment.