assert: improve error check

Minor performance improvement.
nodejs · Mar 2, 2018 · cc1eae9 · cc1eae9
1 parent 452eed9
commit cc1eae9
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -342,11 +342,14 @@ class AssertionError extends Error {
         red = '\u001b[31m';
       }
       const util = lazyUtil();
-
-      if (actual && actual.stack && actual instanceof Error)
+      if (typeof actual === 'object' && actual !== null &&
+        'stack' in actual && actual instanceof Error) {
         actual = `${actual.name}: ${actual.message}`;
-      if (expected && expected.stack && expected instanceof Error)
+      }
+      if (typeof expected === 'object' && expected !== null &&
+        'stack' in expected && expected instanceof Error) {
         expected = `${expected.name}: ${expected.message}`;
+      }
 
       if (errorDiff === 0) {
         let res = util.inspect(actual);