src: fix u-a-free if uv returns err in ASYNC_CALL

PR-URL: #3049 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
nodejs · Oct 8, 2015 · ccaaae9 · ccaaae9
1 parent a9d42e0
commit ccaaae9
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/node_file.cc b/src/node_file.cc
@@ -273,8 +273,10 @@ struct fs_req_wrap {
     uv_req->result = err;                                                     \
     uv_req->path = nullptr;                                                   \
     After(uv_req);                                                            \
-  }                                                                           \
-  args.GetReturnValue().Set(req_wrap->persistent());
+    req_wrap = nullptr;                                                       \
+  } else {                                                                    \
+    args.GetReturnValue().Set(req_wrap->persistent());                        \
+  }
 
 #define ASYNC_CALL(func, req, ...)                                            \
   ASYNC_DEST_CALL(func, req, nullptr, __VA_ARGS__)                            \
@@ -1028,6 +1030,7 @@ static void WriteString(const FunctionCallbackInfo<Value>& args) {
     uv_req->result = err;
     uv_req->path = nullptr;
     After(uv_req);
+    return;
   }
 
   return args.GetReturnValue().Set(req_wrap->persistent());