repl: add autocomplete support for fs.promises

PR-URL: #29400 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
nodejs · Sep 20, 2019 · d57d47b · d57d47b
1 parent 21bc6da
commit d57d47b
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 30 deletions.
diff --git a/lib/repl.js b/lib/repl.js
@@ -1005,6 +1005,7 @@ ArrayStream.prototype.resume = function() {};
 ArrayStream.prototype.write = function() {};
 
 const requireRE = /\brequire\s*\(['"](([\w@./-]+\/)?(?:[\w@./-]*))/;
+const fsAutoCompleteRE = /fs(?:\.promises)?\.\s*[a-z][a-zA-Z]+\(\s*["'](.*)/;
 const simpleExpressionRE =
     /(?:[a-zA-Z_$](?:\w|\$)*\.)*[a-zA-Z_$](?:\w|\$)*\.?$/;
 
@@ -1173,7 +1174,7 @@ function complete(line, callback) {
     }
 
     completionGroupsLoaded();
-  } else if (match = line.match(/fs\.\s*[a-z][a-zA-Z]+\(\s*["'](.*)/)) {
+  } else if (match = line.match(fsAutoCompleteRE)) {
 
     let filePath = match[1];
     let fileList;

diff --git a/test/parallel/test-repl-tab-complete.js b/test/parallel/test-repl-tab-complete.js
@@ -402,37 +402,39 @@ testMe.complete('obj.', common.mustCall((error, data) => {
   putIn.run(['.clear']);
   process.chdir(__dirname);
 
-  const readFileSync = 'fs.readFileSync("';
-  const fixturePath = `${readFileSync}../fixtures/test-repl-tab-completion`;
+  const readFileSyncs = ['fs.readFileSync("', 'fs.promises.readFileSync("'];
   if (!common.isWindows) {
-    testMe.complete(fixturePath, common.mustCall((err, data) => {
-      assert.strictEqual(err, null);
-      assert.ok(data[0][0].includes('.hiddenfiles'));
-      assert.ok(data[0][1].includes('hellorandom.txt'));
-      assert.ok(data[0][2].includes('helloworld.js'));
-    }));
+    readFileSyncs.forEach((readFileSync) => {
+      const fixturePath = `${readFileSync}../fixtures/test-repl-tab-completion`;
+      testMe.complete(fixturePath, common.mustCall((err, data) => {
+        assert.strictEqual(err, null);
+        assert.ok(data[0][0].includes('.hiddenfiles'));
+        assert.ok(data[0][1].includes('hellorandom.txt'));
+        assert.ok(data[0][2].includes('helloworld.js'));
+      }));
 
-    testMe.complete(`${fixturePath}/hello`,
-                    common.mustCall((err, data) => {
-                      assert.strictEqual(err, null);
-                      assert.ok(data[0][0].includes('hellorandom.txt'));
-                      assert.ok(data[0][1].includes('helloworld.js'));
-                    })
-    );
-
-    testMe.complete(`${fixturePath}/.h`,
-                    common.mustCall((err, data) => {
-                      assert.strictEqual(err, null);
-                      assert.ok(data[0][0].includes('.hiddenfiles'));
-                    })
-    );
-
-    testMe.complete(`${readFileSync}./xxxRandom/random`,
-                    common.mustCall((err, data) => {
-                      assert.strictEqual(err, null);
-                      assert.strictEqual(data[0].length, 0);
-                    })
-    );
+      testMe.complete(`${fixturePath}/hello`,
+                      common.mustCall((err, data) => {
+                        assert.strictEqual(err, null);
+                        assert.ok(data[0][0].includes('hellorandom.txt'));
+                        assert.ok(data[0][1].includes('helloworld.js'));
+                      })
+      );
+
+      testMe.complete(`${fixturePath}/.h`,
+                      common.mustCall((err, data) => {
+                        assert.strictEqual(err, null);
+                        assert.ok(data[0][0].includes('.hiddenfiles'));
+                      })
+      );
+
+      testMe.complete(`${readFileSync}./xxxRandom/random`,
+                      common.mustCall((err, data) => {
+                        assert.strictEqual(err, null);
+                        assert.strictEqual(data[0].length, 0);
+                      })
+      );
+    });
   }
 }