fixup! test: re-implement promises.setInterval() test robustly

nodejs · Feb 6, 2021 · d676d1d · d676d1d
1 parent c78b44a
commit d676d1d
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/test/parallel/test-timers-promisified.js b/test/parallel/test-timers-promisified.js
@@ -321,11 +321,14 @@ process.on('multipleResolves', common.mustNotCall());
 }
 
 {
-  async function runInterval(fn, intervalTime, signal) {
+  async function runInterval(fn, intervalTime, signal, emitter) {
     const input = 'foobar';
     const interval = setInterval(intervalTime, input, { signal });
     let iteration = 0;
     for await (const value of interval) {
+      if (emitter) {
+        emitter.emit('myevent');
+      }
       assert.strictEqual(value, input);
       iteration++;
       await fn(iteration);
@@ -359,18 +362,21 @@ process.on('multipleResolves', common.mustNotCall());
     const delay = 10;
     let totalIterations = 0;
     const timeoutLoop = runInterval(async (iterationNumber) => {
-      myEvent.emit('myevent');
-      // The call to abort() will typically happen while we're awaiting here.
-      await setTimeout(delay);
+      if (iterationNumber <= 2) {
+        assert.strictEqual(signal.aborted, false);
+      }
       if (iterationNumber === 2) {
         myEvent.once('myevent', () => {
           controller.abort();
         });
       }
+      if (iterationNumber > 2) {
+        assert.strictEqual(signal.aborted, true);
+      }
       if (iterationNumber > totalIterations) {
         totalIterations = iterationNumber;
       }
-    }, delay, signal);
+    }, delay, signal, myEvent);
 
     timeoutLoop.catch(common.mustCall(() => {
       assert.ok(totalIterations >= 3, `iterations was ${totalIterations} < 3`);