http: support server options on createServer

PR-URL: #19461 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Mar 30, 2018 · dac5f67 · dac5f67
1 parent 8a8b43e
commit dac5f67
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/http.js b/lib/http.js
@@ -33,8 +33,8 @@ const {
   ServerResponse
 } = require('_http_server');
 
-function createServer(requestListener) {
-  return new Server(requestListener);
+function createServer(opts, requestListener) {
+  return new Server(opts, requestListener);
 }
 
 function request(options, cb) {

diff --git a/test/parallel/test-http-server-options-incoming-message.js b/test/parallel/test-http-server-options-incoming-message.js
@@ -16,7 +16,7 @@ class MyIncomingMessage extends http.IncomingMessage {
   }
 }
 
-const server = http.Server({
+const server = http.createServer({
   IncomingMessage: MyIncomingMessage
 }, common.mustCall(function(req, res) {
   assert.strictEqual(req.getUserAgent(), 'node-test');