Skip to content

Commit

Permalink
test: update test-set-http-max-http-headers to use node:test
Browse files Browse the repository at this point in the history
This commit updates test/parallel/test-set-http-max-http-headers.js
to use node:test. This test already implemented a test runner, so
it makes sense to use the existing public API.

PR-URL: #56439
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
cjihrig authored and targos committed Jan 13, 2025
1 parent 3d36447 commit dd5ca35
Showing 1 changed file with 8 additions and 29 deletions.
37 changes: 8 additions & 29 deletions test/parallel/test-set-http-max-http-headers.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,10 @@ const common = require('../common');
const assert = require('assert');
const { spawn } = require('child_process');
const path = require('path');
const { suite, test } = require('node:test');
const testName = path.join(__dirname, 'test-http-max-http-headers.js');

const timeout = common.platformTimeout(100);

const tests = [];

function test(fn) {
tests.push(fn);
}

test(function(cb) {
test(function(_, cb) {
console.log('running subtest expecting failure');

// Validate that the test fails if the max header size is too small.
Expand All @@ -30,7 +23,7 @@ test(function(cb) {
}));
});

test(function(cb) {
test(function(_, cb) {
console.log('running subtest expecting success');

const env = Object.assign({}, process.env, {
Expand All @@ -54,13 +47,13 @@ test(function(cb) {
}));
});

// Next, repeat the same checks using NODE_OPTIONS if it is supported.
if (!process.config.variables.node_without_node_options) {
const skip = process.config.variables.node_without_node_options;
suite('same checks using NODE_OPTIONS if it is supported', { skip }, () => {
const env = Object.assign({}, process.env, {
NODE_OPTIONS: '--max-http-header-size=1024'
});

test(function(cb) {
test(function(_, cb) {
console.log('running subtest expecting failure');

// Validate that the test fails if the max header size is too small.
Expand All @@ -74,7 +67,7 @@ if (!process.config.variables.node_without_node_options) {
}));
});

test(function(cb) {
test(function(_, cb) {
// Validate that the test now passes if the same limit is large enough.
const args = ['--expose-internals', testName, '1024'];
const cp = spawn(process.execPath, args, { env, stdio: 'inherit' });
Expand All @@ -85,18 +78,4 @@ if (!process.config.variables.node_without_node_options) {
cb();
}));
});
}

function runTest() {
const fn = tests.shift();

if (!fn) {
return;
}

fn(() => {
setTimeout(runTest, timeout);
});
}

runTest();
});

0 comments on commit dd5ca35

Please sign in to comment.