fixup! perf_hooks: reduce overhead of new user timings

nodejs · Oct 1, 2023 · df6db01 · df6db01
1 parent 5fd5fad
commit df6db01
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/lib/internal/perf/observe.js b/lib/internal/perf/observe.js
@@ -171,9 +171,13 @@ function maybeIncrementObserverCount(type) {
   }
 }
 
+const kSkipThrow = Symbol('kSkipThrow');
+
 class PerformanceObserverEntryList {
-  constructor() {
-    throw new ERR_ILLEGAL_CONSTRUCTOR();
+  constructor(skipThrowSymbol = undefined) {
+    if (skipThrowSymbol !== kSkipThrow) {
+      throw new ERR_ILLEGAL_CONSTRUCTOR();
+    }
   }
 
   getEntries() {

diff --git a/lib/internal/perf/usertiming.js b/lib/internal/perf/usertiming.js
@@ -66,17 +66,15 @@ function getMark(name) {
   return ts;
 }
 
-const kEmptyArg = Symbol('kEmptyArg');
-
 class PerformanceMark extends PerformanceEntry {
-  constructor(name = kEmptyArg, options = undefined) {
-    if (name === kEmptyArg) {
+  constructor(name, options = undefined) {
+    if (arguments.length === 0) {
       throw new ERR_MISSING_ARGS('name');
     }
     name = `${name}`;
     if (nodeTimingReadOnlyAttributes.has(name))
       throw new ERR_INVALID_ARG_VALUE('name', name);
-    if (options !== undefined) {
+    if (options != null) {
       validateObject(options, 'options');
     }
     const startTime = options?.startTime ?? now();
@@ -86,8 +84,6 @@ class PerformanceMark extends PerformanceEntry {
     markTimings.set(name, startTime);
 
     let detail = options?.detail;
-    // The usage of != is intentional, we want to skip structuredClone
-    // for both undefined and null
     detail = detail != null ?
       structuredClone(detail) :
       null;