Skip to content

Commit

Permalink
test: fix test-require-symlink on Windows
Browse files Browse the repository at this point in the history
Creating directory symlinks on Windows require 'dir' parameter to be
provided.

Fixes: #23596

PR-URL: #23691
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
bzoz authored and targos committed Oct 24, 2018
1 parent 3b66a8d commit dfecf85
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/parallel/test-require-symlink.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const linkScriptTarget = path.join(dirName, 'symlinked.js');
test();

function test() {
fs.symlinkSync(linkTarget, linkDir);
fs.symlinkSync(linkTarget, linkDir, 'dir');
fs.symlinkSync(linkScriptTarget, linkScript);

// load symlinked-module
Expand Down

0 comments on commit dfecf85

Please sign in to comment.