Skip to content

Commit

Permalink
test: http2 add timeout no callback test case
Browse files Browse the repository at this point in the history
Refs: #14985
PR-URL: #16082
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information
trivikr authored and mcollina committed Oct 16, 2017
1 parent 4cf56ad commit e2015b5
Showing 1 changed file with 26 additions and 25 deletions.
51 changes: 26 additions & 25 deletions test/parallel/test-http2-server-settimeout-no-callback.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,38 +4,39 @@ const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');

const assert = require('assert');
const http2 = require('http2');

// Verify that setTimeout callback verifications work correctly
const verifyCallbacks = (server) => {
const testTimeout = 10;
const notFunctions = [true, 1, {}, [], null, 'test'];
const invalidCallBackError = {
type: TypeError,
code: 'ERR_INVALID_CALLBACK',
message: 'Callback must be a function'
};

notFunctions.forEach((notFunction) =>
common.expectsError(
() => server.setTimeout(testTimeout, notFunction),
invalidCallBackError
)
);

// No callback
const returnedVal = server.setTimeout(testTimeout);
assert.strictEqual(returnedVal.timeout, testTimeout);
};

// Test with server
{
const server = http2.createServer();
common.expectsError(
() => server.setTimeout(10, 'test'),
{
code: 'ERR_INVALID_CALLBACK',
type: TypeError
});
common.expectsError(
() => server.setTimeout(10, 1),
{
code: 'ERR_INVALID_CALLBACK',
type: TypeError
});
verifyCallbacks(server);
}

// Test with secure server
{
const server = http2.createSecureServer({});
common.expectsError(
() => server.setTimeout(10, 'test'),
{
code: 'ERR_INVALID_CALLBACK',
type: TypeError
});
common.expectsError(
() => server.setTimeout(10, 1),
{
code: 'ERR_INVALID_CALLBACK',
type: TypeError
});
const secureServer = http2.createSecureServer({});
verifyCallbacks(secureServer);
}

0 comments on commit e2015b5

Please sign in to comment.